Re: Trying to advance fabric ....


Brian Behlendorf <bbehlendorf@...>
 

Thanks for raising the pull request notice here - I'd encourage folks to comment on the PR itself, bringing it back here if there's anything controversial.

I think that should also be done by developers for other pull requests that propose additions or changes to the functionality or protocol, or even bug fixes with ramifications on performance or tests. That would help avoid the issue of things "languishing" in the queue, since few people are as crazy as I am to subscribe to the Github firehose, and even with that firehose it's hard to see when something is going unattended. The Fabric weekly calls should be an opportunity to also perform a sort of breadth-first traversal of unattended proposal PRs to give some quick feedback, to make sure that contributions from new participants (no matter who they work for) aren't being ignored.

Re the earlier PRs mentioned below - could other developers take a look and give it some feedback?

Brian

On 07/06/2016 02:56 AM, Tamas Blummer wrote:
Gabor Hosszu (Digital Asset) submitted a notable new pull request to fabric: https://github.com/hyperledger/fabric/pull/2101

Its motivation is to move code base toward the consensus architecture proposed by Marko Vukolic (IBM), here: https://github.com/hyperledger/fabric/wiki/Next-Consensus-Architecture-Proposal
The proposal was discussed and supported by the Architecture Working Group.

The promise of the proposal is higher scalability through decoupling consensus on order and consistency from endorsement that includes computation of chain code.

This PR introduces a consensus service API and an endorser API which mark the separation line between these future services. The PR is a viable first step of a refactoring effort that has long way to go.

I hope the PR will not share the fate of our (Digital Asset) other attempts to advance fabric, and starve in the PR queue:

#1754 Add transaction rejection events: https://github.com/hyperledger/fabric/pull/1754
#1722 Add noop system chaincode https://github.com/hyperledger/fabric/pull/1722
#1719 Do not store failed transactions into the ledger https://github.com/hyperledger/fabric/pull/1719

The newest PR is #2103 therefore I conclude that 385 other PRs were processed by maintainers in the meanwhile, one of them was ours.

TAMAS BLUMMER
CHIEF LEDGER ARCHITECT
Digital Asset

T: +36 1 883 0300
E: tamas@...
W: digitalasset.com

--
Brian Behlendorf
Executive Director at the Hyperledger Project
bbehlendorf@...
Twitter: @brianbehlendorf

Join fabric@lists.hyperledger.org to automatically receive all group messages.